Skip to content

FIX: Only write DeadtimeFileName to DEE XML config once - #219

Merged
ckierans merged 1 commit into
cositools:develop/emfrom
fhagemann:fix/deadtime-file
Sep 24, 2026
Merged

ckierans merged 1 commit into
cositools:develop/emfrom
fhagemann:fix/deadtime-file

Conversation

@fhagemann

Copy link
Copy Markdown

In the DEE, both MSubModuleStripTrigger and MSubModuleShieldTrigger use the same deadtime parameters file (m_DeadtimeFileName).

The way that ReadXmlConfiguration and CreateXmlConfiguration are implemented right now, we add the tag DeadtimeFileName TWICE to the XmlTagDEESMEX:

<XmlTagDEESMEX>
  <ShieldEnergyCorrectionFileName />
  <DeadtimeFileName />                                   <----- here
  <EnergyCalibrationFileName />
  <DeadtimeFileName>SomeFile.txt</DeadtimeFileName>      <----- and here
  <TACCalFileName />
  <DepthSplineFileName />
  <DepthCoefficientsFileName />
  <ApplyResolutionCalibration>true</ApplyResolutionCalibration>
  <EnableShieldVeto>true</EnableShieldVeto>
  <EnableGuardRingVeto>true</EnableGuardRingVeto>
  <ApplyTimingResolutionCalibration>true</ApplyTimingResolutionCalibration>
</XmlTagDEESMEX>

In this PR, I store the file name in the mother module MModuleDEESMEX and distribute it to the MSubModules, just as it is done for the depth coefficients files that are also used by several MSubModules.

@fhagemann fhagemann added the DEE Development related to the detector effects engine label Sep 24, 2026
@ckierans

Copy link
Copy Markdown
Collaborator

Perfect! Thanks for the quick fix, @fhagemann !

@zoglauer zoglauer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ckierans
ckierans merged commit 6b5c7cd into cositools:develop/em Sep 24, 2026
1 check passed
@fhagemann
fhagemann deleted the fix/deadtime-file branch September 24, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEE Development related to the detector effects engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants