Skip to content

fix(ui): drawer bar overlapping close button - #850

Closed
NathanBrodin wants to merge 1 commit into
cosscom:mainfrom
NathanBrodin:fix/drawer-close-button
Closed

NathanBrodin wants to merge 1 commit into
cosscom:mainfrom
NathanBrodin:fix/drawer-close-button

Conversation

@NathanBrodin

Copy link
Copy Markdown
Contributor

Hi, when showBar and showCloseButton are both enabled, the bar renders on top of the close button and blocks clicks.

before.mp4

I swaped the order so the close button renders last, and added pointer-events-none to DrawerBar since it's decorative (aria-hidden).

after.mp4

I hope this HUGE PR will not be an issue! Love your work!

Render DrawerBar before close button so close stays clickable, and make bar pointer-events-none since it is decorative (aria-hidden).
@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

@NathanBrodin is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
coss-com-origin Skipped Skipped Sep 10, 2026 12:51pm UTC

Request Review

@pasqualevitiello

Copy link
Copy Markdown
Contributor

Thanks for catching this, and for the before/after videos — the overlap is real when showBar and showCloseButton are both enabled.

We're going with a smaller fix: z-1 on the close button so it stacks above the bar. Reordering the DOM and adding pointer-events-none on DrawerBar would unblock clicks, but the bar is the drag affordance (touch-none), so it should keep receiving pointer events. aria-hidden only hides it from assistive tech, not from hit-testing.

Closing this in favor of #851.

This branch was previously deployed

1 inactive deployment
Preview – coss-com-origin 5a1f3832 Deployed Sep 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants