Repository navigation
chore(app): unit tests are found by pattern, so the test script stops conflicting - #112
Merged
Merged
Conversation
… conflicting The test script listed every file by hand, so every branch that added a test conflicted with every other, and resolving those conflicts dropped files: four (mermaid, code-blocks, box-routes, skills-notice-model, 45 tests) had stopped running. `pnpm test` now runs src/lib/**/*.test.ts; the theme contrast test stays with check:themes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/package.json's"test"script listed every unit test file by hand. Every branch that added a test conflicted with every other branch that did. Worse, resolving those conflicts quietly dropped files: onmainright now, four test files never run.src/lib/art/mermaid.test.tssrc/lib/code-blocks.test.tssrc/lib/box-routes.test.tssrc/lib/skills-notice-model.test.tsAll 45 pass.
Now the script is
node --experimental-strip-types --test 'src/lib/**/*.test.ts'. Node 22, which CI uses, expands the quoted pattern itself, so it works the same in any shell. All 66 unit test files live undersrc/lib.src/themes/contrast.test.tsstays out on purpose, becausecheck:themesruns it.Proof
mainThe pattern runs every file exactly once.
Also:
AGENTS.mdnow says new tests go inapp/src/lib/as*.test.ts, with no list to edit.Open #110 adds
header-picture.test.tsto the old list, so it will conflict on this one line. Resolve it by taking this side; the file is found by the pattern.🤖 Generated with Claude Code