Repository navigation
fix(box): new terminals no longer open with a systemd CPUAccounting warning - #116
Merged
Merged
Conversation
…arning systemd 258 and later deprecate CPUAccounting= (cgroup v2 always counts CPU time), and systemd-run printed "D-Bus property CPUAccounting is deprecated" into every new pane, --quiet or not. Session scopes no longer ask for it; cpu.stat's usage_usec is there without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sean-brydon
approved these changes
Oct 15, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On boxes with systemd 258 or later (seen on 259), every new tab printed:
It comes from the
systemd-run --scope … -p CPUAccounting=yesthat wraps each session (internal/box/scopes.go).--quietdoesn't hide it. CPU accounting is always on under cgroup v2, so the property did nothing, and berth's usage numbers readcpu.stat'susage_usec, which the cgroup has without it.-p CPUAccounting=yesfromsystemdScopes.Wrap(MemoryAccounting=yesstays).Checked by hand on systemd 259: the old flags print the warning; the new ones don't, and the scope's
cpu.stat(usage_usec) andmemory.currentare still there.go vet/go testweren't run locally (no Go toolchain on that box); CI covers them.🤖 Generated with Claude Code