Repository navigation
Conversation
|
@Stener1 is attempting to deploy a commit to the seanbrydonio's projects Team on Vercel. A member of the Team first needs to authorize it. |
- A pairing link that worked showed "That pairing link is damaged" and stopped the page: toast() read toastTimer before its let ran (TDZ). - A Home Screen app keeps its own storage and has no address bar, so a link opened in Safari never paired it. The Pair and Boxes screens take a pasted link. - Back used history.back(), which left the app when the tab had other pages behind it; it now returns to the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LQ7gUBM8j8uAh3PWTFSYQa
Stener1
force-pushed
the
phone-pairing-fixes
branch
from
October 13, 2026 14:09
2595c48 to
5e7f59c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes to the phone app, found pairing an iPhone (iOS 26, Safari and a Home Screen app) with two boxes.
A good pairing link said "That pairing link is damaged" and left a blank page.
pairFromLink()runs at load and callstoast(), which readstoastTimer— declared withletfurther down, so it was still in its temporal dead zone. TheReferenceErrorlanded in thecatch, whose owntoast()threw again, stopping the rest ofapp.js. The boxes were saved, so a reload showed them.toastTimernow sits with the other top-level state.A Home Screen app could not be paired by link. iOS gives a Home Screen web app storage of its own, apart from Safari, so a link opened in Safari pairs Safari only — and the Home Screen app has no address bar to open the link in. The Pair screen (and Boxes, for adding one later) now has Or paste a pairing link: the same
#pair=payload, read from pasted text. Parsing moved intopairFrom(text), used by both the fragment and the field; a link carrying no usable box now counts as damaged instead of toasting "Paired with undefined".Back left the app. It called
history.back()wheneverhistory.length > 1, which in a browser tab steps out to whatever came before (the pasted link, the page that linked here). It now returns to the list, as the standalone app already did.The phone guide mentions pasting into the Home Screen app.
Tested in a browser against the patched page (link in the fragment pairs with no error and clears the fragment; a pasted link pairs; Back returns to the list), then on an iPhone Home Screen app against two boxes running this build.
go test ./internal/box -run Phonepasses;node --checkonapp.js.🤖 Generated with Claude Code