Repository navigation
fix(release): a slow notarization of the dmg no longer holds a release - #85
Merged
Merged
Conversation
v0.3.17's Mac build failed three times on Apple: the app was accepted in minutes each time, but the dmg (notarized separately, after the app) was not answered within the hour mac-release.sh waited, and the build on the runner was lost each time. The dmg is now waited for DMG_NOTARY_WAIT (15m). If Apple is still at it, the dmg ships unstapled with a warning and its submission id, and its own stapler and Gatekeeper checks are skipped: the app inside, which macOS checks when it opens, is notarized and stapled and has passed them, and the dmg's ticket reaches Macs online once Apple finishes. A dmg Apple refuses, or a notarytool error, still fails the release. The updater archive, which installed apps update from, is unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.3.17's Mac build failed three times on Apple, which was slow but never refused anything. Every submission was eventually Accepted (
notarytool history). On attempt 3:mac-release.shwaits (Timeout of 3600 second(s) was reached)Each failure discarded the runner's build.
Change (
scripts/mac-release.sh)The dmg's notarization waits
DMG_NOTARY_WAIT(default15m). What happens next depends on Apple's answer:gatekeeper installandstapler validateon the dmg, as before::warning::and the submission id. Skip the dmg's own stapler and Gatekeeper checks. The app inside has already been notarized, stapled and checked (check_appon the app, in the mounted dmg and in the updater archive), and the dmg's ticket reaches Macs online once Apple finishes.The updater archive, which installed apps update from, is unaffected.
Tested:
shellcheck, and the result handling run against Apple's real timeout reply plus accepted, invalid and error replies.To release v0.3.17 with this
v0.3.17 is still a draft that nobody is offered. The only other commit on
mainsince its tag is #84, which is CI-only. After merging, retag it (from.claude/skills/release):🤖 Generated with Claude Code