Fix Explorer false errors and keep settings failures visible - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a server folder could display an empty error dialog even after Explorer opened the folder. Treat Explorer's silent exit status 1 as a successful handoff, while preserving errors with diagnostics and other failure statuses.
Server settings now display Docker and migration failures in a TUI textbox that remains visible until dismissed. Applying settings and saving for later also report their result inside the TUI. Closing settings without edits returns success.
Validation: 142 local specification tests passed; one ZIP test skipped because zip is unavailable. Regression cases cover both Explorer folder actions, actual Explorer failures, Docker diagnostics in the error dialog, no underlying terminal output, and exiting settings without changes.