Repository navigation
[fix][llm] pass pointer when unmarshalling Qwen/Qianfan response format schema - #710
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
…at schema qwenBuilder and qianfanBuilder passed the schema target by value to sonic.UnmarshalString, so any model configured with a ResponseFormatJsonSchema failed to build with 'Unmarshal(non-pointer ...)'. Use &js as openAIBuilder already does, and add builder tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
A Qwen or Qianfan model with a non-empty
ResponseFormatJsonSchemacannot be built: the builder returnsjson: Unmarshal(non-pointer ...)(Qwen) orjson: Unmarshal(nil)(Qianfan).Root cause: in
qwenBuilderandqianfanBuilder(backend/modules/llm/domain/service/llmimpl/eino/init.go),sonic.UnmarshalString(*pc.ResponseFormatJsonSchema, js)passesjsby value.openAIBuilderalready passes&js.Fix: pass
&jsin both builders.Test: new
init_test.gowithTestQwenBuilder_ResponseFormatJSONSchemaandTestQianfanBuilder_ResponseFormatJSONSchema. Both fail without the change and pass with it; the rest of the package passes (go test ./modules/llm/domain/service/llmimpl/eino/).This change was prepared with Claude Code, an AI assistant, on behalf of the contributor.
(Optional) Which issue(s) this PR fixes
None filed; found while reading the builders.