Conversation
This was referenced Sep 7, 2026
Owner
Author
|
Moved to xgo-dev#2527 as requested. Fork CI had already completed and there are no active workflow runs to cancel. Keeping the source branch for the upstream contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Injected Go source patches are added to CompiledGoFiles after go list, but the package cache fingerprints only GoFiles. Editing an injected function body can therefore silently reuse a stale archive. This is a shared main issue found while validating R4's syscall timestamp fix.
Fix
Validation
Focused build/fingerprint tests pass on LLVM 22, independently on upstream main be23e48. R4 also carries the same fix and has passed its cache-enabled wide-stat regression. CI is still required before upstream contribution.
This PR is independent of the WASM runtime changes in #235. Its base is the existing main snapshot branch at be23e48, not the R4 feature branch.