Skip to content

TS-48018 Pass the JaCoCo class loader options on to the profiler #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stahlbauer merged 2 commits into from
Sep 24, 2026
Merged

TS-48018 Pass the JaCoCo class loader options on to the profiler #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce8c5e1
TS-48018 Pass the JaCoCo class loader options on to the profiler
sewe Sep 22, 2026
aab98ef
Merge branch 'master' into ts/48018_include_no_location_classes
stahlbauer Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ We use [semantic versioning](http://semver.org/):
- PATCH version when you make backwards compatible bug fixes.

# Next version
- [fix] _teamscale-gradle-plugin_: `jacoco.includeNoLocationClasses` and `jacoco.excludeClassLoaders` on a test task now reach the profiler. Previously the plugin dropped both, so neither had any effect on which classes the profiler instruments.
- [fix] _teamscale-jacoco-agent_: The profiler no longer aborts the JVM during startup under a class loader that records no local file for its own JAR, such as IntelliJ's `PathClassLoader`. It falls back to the JAR named by the `-javaagent` argument.
- [fix] _impacted-test-engine_: Tests in a `@ParameterizedClass` are now collected.
- [fix] _impacted-test-engine_: A test failure inside a nested test container (e.g. an invocation of a `@ParameterizedClass`) is no longer swallowed.
Expand Down
6 changes: 6 additions & 0 deletions teamscale-gradle-plugin/src/main/kotlin/com/teamscale/config/AgentConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ abstract class AgentConfiguration @Inject constructor(
argument.append("out", destination.asFile.get())
argument.append("includes", jacocoExtension.includes)
argument.append("excludes", jacocoExtension.excludes)
// The profiler replaces JaCoCo's own agent, so a setting it does not forward has no effect at
// all. The agent passes options prefixed `jacoco-` on to JaCoCo.
argument.append("jacoco-exclclassloader", jacocoExtension.excludeClassLoaders)
if (jacocoExtension.isIncludeNoLocationClasses) {
argument.append("jacoco-inclnolocationclasses", true)
}
argument.append("mode", "testwise")
argument.append("http-server-port", url.port)
if (debugLogging.getOrElse(false)) {
Expand Down
Loading