Set the external-dns hostname annotation under both the alpha and new prefix - #895
Merged
Merged
Conversation
goat-ssh
reviewed
Sep 1, 2026
goat-ssh
approved these changes
Sep 1, 2026
tomach
reviewed
Sep 2, 2026
WalBeh
force-pushed
the
fix/external-dns-annotation-prefix
branch
from
September 2, 2026 10:08
dd93746 to
2cdd662
Compare
… prefix external-dns v0.22.0 changed its default annotation prefix from external-dns.alpha.kubernetes.io/ to external-dns.kubernetes.io/ with no fallback to the old one. Set the hostname annotation under both prefixes on the data service and the grand-central Ingress, and add a uv backfill script that copies the value onto existing operator-managed resources. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
WalBeh
force-pushed
the
fix/external-dns-annotation-prefix
branch
from
September 2, 2026 14:52
73f9cb6 to
a024b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
external-dns v0.22.0 changes the default annotation prefix from
external-dns.alpha.kubernetes.io/toexternal-dns.kubernetes.io/, with no fallback to the old prefix. The operator now sets the hostname annotation under both prefixes (option 1 in the issue: "two won't hurt") on:_lb_annotations_to_add, plus removal via_lb_annotations_to_removewhen switching to Traefik)IngressBoth keys live in
constants.pywith a note to drop the alpha one once all external-dns controllers are confirmed on v0.22.0+.For existing clusters (item 2 in the issue),
devtools/backfill_external_dns_annotation.py— a uv script (PEP 723 inline metadata, click CLI) — copies the alpha annotation's value to the new key on operator-managed Services and Ingresses only, selected viaapp.kubernetes.io/managed-by=crate-operator,app.kubernetes.io/part-of=cratedb. It dry-runs by default, takes--applyto patch and--contextto pick a kubeconfig context, skips resources that already have the new annotation, and reports per-resource failures without aborting the sweep (non-zero exit if any). Run once per region:Still out of scope: pinning
--annotation-prefix/ bumping external-dns on the deployments in kubernetes-gitops (item 3).Checklist
CHANGES.rst🤖 Generated with Claude Code