Fix grand-central exposure convergence - #899
Merged
Merged
Conversation
tomach
force-pushed
the
ta/fix-gc-exposure-convergence
branch
from
September 4, 2026 07:24
3ad406e to
d1e3c3e
Compare
tomach
force-pushed
the
ta/fix-gc-exposure-convergence
branch
from
September 8, 2026 08:48
d1e3c3e to
7ef45c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
When
spec.cluster.exposurechanged whilespec.grandCentral.exposurewas unset, grand-central's routing didn't converge via the fallback, leaving a stale nginx Ingress behind. This fixes it, somigrate_grand_central_exposureis now convergent and idempotent, andChangeGrandCentralExposureSubHandleralways reconciles instead of doing nothing when the effective value looks unchangedChecklist
CHANGES.rst