chore(docblock): declare server config shape once via @phpstan-type (closes #594) - #820
Merged
s2x merged 5 commits intoSep 13, 2026
Merged
Conversation
s2x
deleted the
chore/issue-594-server-config-array-shape-is-duplicated
branch
September 13, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #594
Changes
@phpstan-type ServerConfigalias onCrazyGoat\WorkermanBundle\Worker\ServerWorker.WorkermanBundlewith@phpstan-import-type;servers?is nowlist<ServerConfig>.ServerWorker::{__construct,configureHandler,createSslContext}and the nested shape onWorkermanBundle::loadExtensionwith the alias.serve_files,root_dirandstatic_filesas deprecated inside the alias, namingStaticFilesMiddlewareand removal in 1.0 (consistent withUPGRADE.md).Changelog
Entry added under
[Unreleased] > Changed.Proof of Work
docs/proof_of_work/0594-server-config-phpstan-type/— 3 review round(s), 0 open findings.Code Review