Skip to content

fix(server): initialize OpenTelemetry from config/otel.yaml - #1099

Merged
randy-cro merged 4 commits into
developfrom
feat/otel-config
Sep 16, 2026
Merged

randy-cro merged 4 commits into
developfrom
feat/otel-config

Conversation

@randy-cro

@randy-cro randy-cro commented Sep 16, 2026

Copy link
Copy Markdown

cosmos-sdk bootstraps OTel in server.start, but is not present in ethermint, so when cronos starts <home>/config/otel.yaml is never read: instruments configured there stayed attached to the noop provider and emitted nothing.

Missing and empty files remain a no-op, so nodes without a configured otel.yaml are unaffected.

@randy-cro
randy-cro requested a review from a team as a code owner September 16, 2026 05:24
@randy-cro
randy-cro requested review from JayT106 and thomas-nguy and removed request for a team September 16, 2026 05:24
@github-actions

This comment has been minimized.

randy-cro added a commit that referenced this pull request Sep 16, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
The SDK bootstraps OTel in server.start, which this command replaces, so
<home>/config/otel.yaml was never read: instruments configured there stayed
attached to the noop provider and emitted nothing.

Missing and empty files remain a no-op, so nodes without a configured
otel.yaml are unaffected.

Co-Authored-By: Claude <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.06%. Comparing base (d263d89) to head (44e4f5d).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
server/start.go 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1099      +/-   ##
===========================================
+ Coverage    47.03%   47.06%   +0.02%     
===========================================
  Files          200      200              
  Lines        17626    17637      +11     
===========================================
+ Hits          8291     8300       +9     
- Misses        8473     8475       +2     
  Partials       862      862              
Files with missing lines Coverage Δ
server/start.go 1.38% <0.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: thomas-nguy <81727899+thomas-nguy@users.noreply.github.com>
auto-merge was automatically disabled September 16, 2026 08:04

Head branch was pushed to by a user without write access

Copilot AI and others added 2 commits September 16, 2026 08:07
Co-authored-by: thomas-nguy <81727899+thomas-nguy@users.noreply.github.com>
Co-authored-by: thomas-nguy <81727899+thomas-nguy@users.noreply.github.com>
Copilot AI requested a review from thomas-nguy September 16, 2026 08:11
@randy-cro
randy-cro merged commit bdf57ba into develop Sep 16, 2026
41 of 42 checks passed
@randy-cro
randy-cro deleted the feat/otel-config branch September 16, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants