test(rpc): pin execution-apis ref and fix two new spec cases - #1100
Merged
Merged
Conversation
randy-cro
requested review from
JayT106 and
thomas-nguy
and removed request for
a team
September 16, 2026 08:29
thomas-nguy
approved these changes
Sep 16, 2026
randy-cro
enabled auto-merge (squash)
September 16, 2026 08:38
This was referenced Sep 16, 2026
randy-cro
force-pushed
the
fix/rpc-spec-schema-pin
branch
from
September 16, 2026 09:57
9fc0a49 to
f3d439e
Compare
The schema suite downloaded ethereum/execution-apis at HEAD of main, so its inputs changed with no commit here. Two cases added upstream after the suite last ran then failed on the next PR that touched Go code, neither of them an ethermint defect: - eth_getLogs/filter-error-future-block-to-latest replays fromBlock=0x38 literally, which is a committed block on the local chain, so returning no logs is correct. Its sibling filter-error-future-block-range is already rewritten for the local chain; do the same here, moving only fromBlock past the head and leaving toBlock as "latest". - testing_commitBlockV1/commit-block-with-transactions compares against a local block whose transaction is legacy while the fixture's is type 0x2, so accessList/maxFeePerGas/maxPriorityFeePerGas/yParity are absent for the right reason. Pin the ref so the next spec change arrives as a reviewable diff that updates these lists, rather than as a red build on an unrelated PR. Co-Authored-By: Claude <noreply@anthropic.com>
filter-error-fully-future-block-range asks for 0x38..0x3a, which is a valid past range once the local chain passes height 58 — so it depends on where the chain happens to be and flips between runs. Move both bounds past the head so it keeps asserting what the spec case is about: from > head rather than only to > head, which is its sibling's job. Co-Authored-By: Claude <noreply@anthropic.com>
randy-cro
force-pushed
the
fix/rpc-spec-schema-pin
branch
from
September 16, 2026 09:59
f3d439e to
2bcc264
Compare
…fix/rpc-spec-schema-pin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema suite downloaded ethereum/execution-apis at HEAD of main, so its
inputs changed with no commit here. Two cases added upstream after the suite
last ran then failed on the next PR that touched Go code, neither of them an
ethermint defect:
eth_getLogs/filter-error-future-block-to-latest replaysfromBlock=0x38literally, which is a committed block on the local chain, so returning no
logs is correct. Its sibling filter-error-future-block-range is already
rewritten for the local chain; do the same here, moving only fromBlock past
the head and leaving toBlock as "latest".
testing_commitBlockV1/commit-block-with-transactionscompares against alocal block whose transaction is legacy while the fixture's is type 0x2, so
accessList/maxFeePerGas/maxPriorityFeePerGas/yParity are absent for the
right reason.
Pin the ref so the next spec change arrives as a reviewable diff that updates
these lists, rather than as a red build on an unrelated PR.