Skip to content

Enable multi-arch build #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclerget merged 1 commit into from
Dec 16, 2025
Merged

Enable multi-arch build #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Build/Push to GitHub Container Registry
run:
make push-multiarch PULL_BASE_REF=$(git describe --tags --abbrev=0) REGISTRY_NAME=ghcr.io/ctrliq BUILD_PLATFORMS="linux amd64 amd64 -amd64; linux arm64 arm64 -arm64"

Copilot AI Dec 16, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BUILD_PLATFORMS parameter format appears incorrect. Based on the build.make file (line 162), the format expects space-separated fields per platform entry: "os arch buildx_platform suffix base_image addon_image".

The current format has duplicated "amd64 amd64" and "arm64 arm64" which doesn't match the expected pattern. According to the example in build.make (line 135), it should be "linux amd64" (os and arch) or "linux amd64 amd64 -amd64" when specifying buildx_platform and suffix.

Consider using: BUILD_PLATFORMS="linux amd64; linux arm64"

Suggested change
make push-multiarch PULL_BASE_REF=$(git describe --tags --abbrev=0) REGISTRY_NAME=ghcr.io/ctrliq BUILD_PLATFORMS="linux amd64 amd64 -amd64; linux arm64 arm64 -arm64"
make push-multiarch PULL_BASE_REF=$(git describe --tags --abbrev=0) REGISTRY_NAME=ghcr.io/ctrliq BUILD_PLATFORMS="linux amd64; linux arm64"

Copilot uses AI. Check for mistakes.