Skip to content

docs: remove the pull request commit step from the Detox page [ENG-934] - #85

Merged
agoldis merged 2 commits into
mainfrom
docs/detox-pull-request-commit
Sep 24, 2026
Merged

agoldis merged 2 commits into
mainfrom
docs/detox-pull-request-commit

Conversation

@agoldis

@agoldis agoldis commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Removes the "Pull requests in GitHub Actions" step from the Detox page. @currents/cmd 1.11.0-beta.2 records the last commit of the pull request when GitHub Actions checks out a merge commit, so users no longer need to set COMMIT_INFO_* before currents upload.

  • The beta version in the hint changes from 1.11.0-beta.1 to 1.11.0-beta.2.
  • "Earlier versions" says 1.11.0-beta.1 records the merge commit.

Merge after @currents/cmd 1.11.0-beta.2 is published with the beta tag. Example project: currents-dev/currents-examples#16.

Code: currents-dev/commit-info#9, currents-dev/currents-reporter#421. Linear: ENG-934.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LdJrRhBLEH9Uwt97JMGVTR

Summary by CodeRabbit

  • Documentation
    • Updated the Detox and Jest setup guide to reference @currents/cmd version 1.11.0-beta.2.
    • Clarified that in GitHub Actions pull_request workflows, version 1.11.0-beta.1 displays GitHub’s merge commit instead of the pull request’s latest commit.
    • Removed the previous guidance and workflow example for overriding commit metadata.

@currents/cmd 1.11.0-beta.2 records the last commit of the pull request
when GitHub Actions checks out a merge commit, so the COMMIT_INFO_* step is
no longer needed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LdJrRhBLEH9Uwt97JMGVTR
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 49 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 63 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 397332d0-00ac-4b0e-a616-e303dc25fc9f

📥 Commits

Reviewing files that changed from the base of the PR and between 1631532 and 3b5cff0.

📒 Files selected for processing (1)
  • getting-started/other-frameworks/jest/detox-+-jest.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 4426f8b9-3427-4f5f-8ccf-4ae81ab19a1f

📥 Commits

Reviewing files that changed from the base of the PR and between 7311ea2 and 1631532.

📒 Files selected for processing (1)
  • getting-started/other-frameworks/jest/detox-+-jest.md

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The Detox and Jest guide updates the documented @currents/cmd beta version and replaces its GitHub Actions commit metadata override guidance with a note about beta 1.11.0-beta.1.

Changes

Detox and Jest guide

Layer / File(s) Summary
Version and GitHub Actions guidance
getting-started/other-frameworks/jest/detox-+-jest.md
The guide updates @currents/cmd from 1.11.0-beta.1 to 1.11.0-beta.2. It removes the workflow example for setting COMMIT_INFO_* variables and notes that beta 1.11.0-beta.1 displays GitHub’s merge commit on pull_request workflows.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 16315

The guide points readers to a published beta version whose inspected implementation supports reporting the pull request’s last commit in the documented GitHub Actions workflow. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing the pull request commit step from the Detox documentation page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@baz-reviewer

baz-reviewer Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Update the Detox/Jest setup guide to require @currents/cmd 1.11.0-beta.2, which automatically records the pull request’s head commit in GitHub Actions. Remove the manual COMMIT_INFO_* workflow override and document the behavior of 1.11.0-beta.1 for earlier users.

Latest Contributors(2)
UserCommitDate
agoldis@gmail.comdocs: link the Detox b...September 24, 2026
agoldis@users.noreply....docs: document Detox s...September 23, 2026

Merger  Activate to get a short verdict whether this PR is good to go or not

Skills  Activate Skill Maintainer to keep your skills up to date

Planner  This PR would have been improved with Baz Planner - Try it now

Comment thread getting-started/other-frameworks/jest/detox-+-jest.md
Comment thread getting-started/other-frameworks/jest/detox-+-jest.md Outdated
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LdJrRhBLEH9Uwt97JMGVTR
@agoldis
agoldis merged commit e1fc7bb into main Sep 24, 2026
5 checks passed
@agoldis
agoldis deleted the docs/detox-pull-request-commit branch September 24, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant