Skip to content

fix(explore): remove music server shortcut and stabilize emulator CI - #624

Merged
cwuom merged 2 commits into
masterfrom
fix/remove-explore-music-server
Oct 31, 2026
Merged

cwuom merged 2 commits into
masterfrom
fix/remove-explore-music-server

Conversation

@cwuom

@cwuom cwuom commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

描述 / Description

Remove the music server shortcut above the Explore search field while keeping Library and account settings access.

Stabilize emulator fixtures and allow one complete-lane recovery only when every real failure matches a verified window-focus readiness signature. Business assertions, unknown failures, incomplete reports, a second failure, missing cases and newly skipped cases remain blocking.

类型 / Type

  • Bug 修复 / Bug Fix
  • 新功能 / New Feature
  • 文档更新 / Documentation Update
  • 其他(请描述)/ Other (please describe):

修复或解决的问题 / Issues Fixed or Closed by This PR

Requested Explore cleanup and the emulator failures in Android CI run 41101295304 (shards 2 and 3).

清单 / Checklist

  • 我已阅读并遵循贡献指南 / I have read and followed the contribution guidelines
  • 我已在本地测试这些更改 / I have tested these changes locally
  • 我已更新相关文档或注释(如适用) / I have updated relevant documentation or comments (if applicable)
  • 我确认本次更改没有破坏任何原有逻辑 / I confirm this change does not break existing behavior
  • 我确认本次更改保持向下兼容(如适用) / I confirm this change remains backward compatible (if applicable)
  • 我已运行必要的构建、测试或静态检查 / I have run the required build, tests, or static checks
  • 我确认没有提交密钥、Token 或其他敏感信息 / I confirm no secrets, tokens, or other sensitive information were committed
  • 涉及 UI 变更时,我已补充截图或录屏(如适用) / I have added screenshots or recordings for UI changes (if applicable)

其他信息 / Additional Information

The offline fixture waits for the terminal Wi-Fi disabled state before handing control to a test. Native Back input checks the owning window focus, uses UiAutomation injection and verifies delivery. Failure diagnostics now include the filtered app windows and input state.

The CI wrapper preserves all module tasks, shard arguments and assertions. A qualifying first failure is archived as XML/HTML/logcat in an opaque ZIP before the entire unchanged lane is run once more. The replay must contain the same complete testcase identities and cannot introduce skips.

Validation:

  • Debug and AndroidTest APK builds passed.
  • 15 targeted API 35 instrumented tests passed, including the original failing methods and native input focus regression.
  • Three additional repetitions of the offline fixture passed all 6 tests.
  • Python automation tests: 54 passed, including 18 recovery tests; Node tests: 31 passed; Ruby checks and actionlint 1.7.12 passed.
  • The original shard 2 reports correctly reject recovery because their two business assertion failures are not on the readiness allowlist; only the 8 focus-only failures qualify individually.
  • Local :app:lintDebug passed with 0 errors; existing warnings remain in unchanged files.
  • Remote Automation checks and the full Android CI run passed for 6bcd6214f5d13df3345a88c99d6559fd96c9efab, including all six emulator groups, Gradle/quality/lint gates, Release build and final report/APK verification.
  • The aggregate inventory contains 1,555 app and 150 library cases: 1,663 passed and 42 conditionally skipped. All 11 originally failing cases and the new native Back regression executed and passed. Both originally failing shards passed on their first attempt; recovery was not triggered.

The earlier OnePlus signed Release overwrite-install evidence applies to 9b51376b8.10310140. The four opt-in Explore UI cases still require their dedicated Navidrome fixture and AVD; they were compiled but not executed.

Explore 页面不再显示音乐服务器入口。用户仍可从 Library 和账户设置访问音乐服务器。

现有 4 个 UI 用例已更新,覆盖 Clean、Material 主题及明暗模式,检查 Explore 搜索框、入口缺失和 Library 访问。用例已编译,但未执行。

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T01:10:22.843055Z 6bcd621 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9b51376 and 6bcd621.

Files selected for processing: 10
  • .github/scripts/run_connected_tests.py
  • .github/scripts/test_run_connected_tests.py
  • .github/workflows/android_ci.yml
  • app/src/androidTest/java/moe/ouom/neriplayer/testutil/EmulatorOfflineNetworkFixture.kt
  • app/src/androidTest/java/moe/ouom/neriplayer/testutil/EmulatorOfflineNetworkFixtureTest.kt
  • app/src/androidTest/java/moe/ouom/neriplayer/testutil/NativeTouchInput.kt
  • app/src/androidTest/java/moe/ouom/neriplayer/testutil/NativeTouchInputTest.kt
  • app/src/androidTest/java/moe/ouom/neriplayer/testutil/UiFailureDiagnostics.kt
  • app/src/androidTest/java/moe/ouom/neriplayer/ui/screen/NowPlayingPortraitImmersiveLayoutTest.kt
  • app/src/androidTest/java/moe/ouom/neriplayer/ui/screen/nowplaying/MoreOptionsSheetPredictiveBackTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

Explore 搜索面板不再显示音乐服务器入口。测试在四种主题与明暗组合下检查 Explore 中入口不可见,并验证返回 Library 后入口仍可见。Android CI 新增连接测试脚本,用于识别特定焦点故障并在符合条件时恢复模拟器后重跑。原生返回测试改用新的输入辅助方法。离线网络检查新增 Wi-Fi 禁用状态广播验证。

Merge Risk: Minimal · up to 6bcd6

The change is mergeable after normal checks; the reported instrumented UI cases have not been executed in their required fixture.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题准确概括了移除 Explore 音乐服务器快捷入口和稳定模拟器 CI 的主要变更,内容清晰且简洁。
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 26 functions across 10 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cwuom cwuom changed the title fix(explore): remove music server shortcut fix(explore): remove music server shortcut and stabilize emulator CI Oct 31, 2026
@cwuom
cwuom merged commit 52aeff8 into master Oct 31, 2026
13 checks passed
@cwuom
cwuom deleted the fix/remove-explore-music-server branch October 31, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant