Skip to content

Fix/xelis - #1425

Draft
danrmiller wants to merge 8 commits into
stagingfrom
fix/xelis
Draft

Fix/xelis#1425
danrmiller wants to merge 8 commits into
stagingfrom
fix/xelis

Conversation

@danrmiller

Copy link
Copy Markdown
Collaborator

This is from @sneurlax and it has some generated dart.g files I did not include so I made this draft PR to make it easier for me look into that more closely. Don't merge it as-is, there are some things we might not want like changing the xelis_ffi from upstream to a manymath fork.

Pin Flutter 3.44.8 and Rust 1.91.0 across CI, container images, build documentation, and helper scripts. Bootstrap container jobs so the first staging build is not coupled to CI image rebuild timing.

Verified: workflow YAML parsed successfully, rust_version.sh passed bash syntax checking, and the staged diff passed git diff --check.
Keep the no-secret pull-request path aligned with scripts/prebuild.sh so exchange imports compile when repository secrets are unavailable.

Verified: test workflow YAML parsed successfully and the staged diff passed git diff --check.
Upgrade xelis_dart_sdk to 0.35.1 and xelis_flutter to v0.3.0. Move Isar to 3.3.2 with the analyzer 10 / Hive CE 1.11.1 generator graph, regenerate schemas, and retain the generated Hive registrar.

Handle the new pending-transaction wallet event without treating it as finalized, and add an API smoke test. Regenerating the lockfile also restores unrelated entries that the original update branch had resolved against stale template inputs.

Verified on Flutter 3.44.8 / Dart 3.12.2: pub get succeeded; build_runner wrote 0 additional outputs; focused Xelis, Hive, and Isar tests passed 16/16; Xelis cargo check completed with Rust 1.91.0; scoped analyzer reported no errors; formatting and git diff checks passed.
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.46405% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.94%. Comparing base (3248751) to head (ff85741).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
lib/wallets/wallet/impl/xelis_wallet.dart 0.00% 6 Missing ⚠️
lib/wl_gen/interfaces/lib_xelis_interface.dart 75.00% 2 Missing ⚠️
.../wallets/wallet/impl/xelis_transaction_mapper.dart 99.27% 1 Missing ⚠️
.../wallets/wallet/intermediate/lib_xelis_wallet.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1425      +/-   ##
===========================================
+ Coverage     4.75%    4.94%   +0.18%     
===========================================
  Files         1108     1109       +1     
  Lines       110815   110882      +67     
===========================================
+ Hits          5273     5486     +213     
+ Misses      105542   105396     -146     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants