Report an unreachable sbx SSH endpoint in diagnose - #62
Merged
Merged
Conversation
The gateway tunnel runs `sbx ssh proxy`. In a container without the sbx cache, the CLI reads no feature flags and sees the daemon's SSH endpoint as off. The tunnel then fails, but diagnose still passed. diagnose now runs `sbx ssh proxy` and requires the daemon's SSH banner. The deployment guide mounts the directory of the daemon socket, not the socket file, and it gives the container the sbx cache and state paths. Refs #61.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway tunnel runs
sbx ssh proxy. In a container without the sbx cache, the CLI reads no feature flags and sees the daemon's SSH endpoint as off. Then the tunnel fails, butdiagnosestill passed, because it ran onlysbx ls.Changes:
diagnosealso runssbx ssh proxythrough the newSbxCLI.check_ssh_endpoint, and it requires the daemon'sSSH-banner. The probe uses a sandbox name that does not exist. The daemon sends its banner before it selects a sandbox, so the probe creates and wakes no sandbox. A CLI that sees the endpoint as off exits with an error, and/doctorreports it.docs/deploy.md:XDG_CACHE_HOMEandXDG_STATE_HOME, and mounts the sbx cache;XDG_CONFIG_HOMEpoints to them.Validation:
uv run pytest: 743 passed on SQLite. Ruff, format checks, and Pyright passed.diagnosewith an unreachable endpoint.check_ssh_endpointpassed against the real daemon, andsbx lsshowed no new sandbox.Not tested: the Linux container recipe. On macOS, sbx keeps its cache in
~/Library/Cachesand ignoresXDG_CACHE_HOME, so the Linux paths come from the issue. The Druks compose change will test them on the deploy host.Refs #61. The compose change for the Druks deployment is still open.