Check a WebSocket's origin against the host of urls.endpoint - #749
Merged
Merged
Conversation
An edge such as Teleport App Access forwards requests with Host set to the app's upstream address, so every WebSocket upgrade failed the same-origin check. The check now compares Origin with the host of urls.endpoint, the address the browser reaches Druks at, and falls back to Host only when urls.endpoint is empty.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some identity edges forward requests with
Hostset to the app's upstream address. Teleport App Access sendsHost: 127.0.0.1:8000while the browser sendsOrigin: https://druks.example.com.is_same_origincomparedOriginwithHost, so it refused every WebSocket upgrade: the chat conversation socket and the login window screen.is_same_originnow comparesOriginwith the host ofurls.endpoint, the address the browser reaches Druks at. Whenurls.endpointis empty, it compares withHostas before. The comparison stays host-only, because a TLS edge hands Drukswswhile the browser'sOriginsayshttps.docs/configuration.mdstates the rule on theurls.endpointrow.Closes #745.