fix(hijacking): height-match CTA arm to control to isolate ad-impression cause#6315
Open
tsahimatsliah wants to merge 2 commits into
Open
fix(hijacking): height-match CTA arm to control to isolate ad-impression cause#6315tsahimatsliah wants to merge 2 commits into
tsahimatsliah wants to merge 2 commits into
Conversation
…ion cause The CTA arm (CatStageHero) of the hijacking_variants2 experiment has been hurting header-ad impressions. The likely culprit is banner height: the arm forced a min-height plus py-10, a brand lockup, a large-title heading, and an accent divider, rendering ~200px taller than the content-driven control on tablet and pushing the head ad down. Collapse the CTA arm to the control's compact height envelope (same p-5/tablet:p-6 padding, same cat-image sizing, no min-height/py-10) while keeping its distinct design (glowing stage backdrop, dual CTAs, own copy). With height held constant, the experiment can tell whether the impression drop comes from height or from the design itself. Removes the now-unused CatHeroImage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rebuilds the CTA arm (
CatStageHero) of thehijacking_variants2experiment to occupy the same vertical height as the control (DefaultHijackingStrip), while keeping its own distinct visual design.Why
The CTA arm has been hurting header-ad impressions. The likely culprit is banner height: the arm forced
min-h-[17.6rem]/tablet:min-h-[22.4rem](~358px) pluspy-10, a brand lockup, atypo-large-titleheading, and an accent divider — rendering ~200px taller than the content-driven control on tablet and pushing the head ad down.Holding height constant across both arms lets the experiment separate the variables and see whether the impression drop is caused by height or by the design itself.
Changes
min-h-*and heavypy-10; adopted the control'sp-5/tablet:p-6padding.flex-col tablet:flex-row items-stretchlayout.BrandLockupand accent-divider rows; heading is nowtypo-title2(matching the control'sh3), with trimmed copy.h-[12.5rem]mobile /tablet:h-auto w-[14.5rem]); removed the now-unusedCatHeroImagecomponent.mt-6→mt-4to match the control.Kept distinct (so it remains a new design, not a control clone): the glowing "stage"/aurora backdrop, the dual Sign up / Log in CTAs, and the arm's own copy.
Notes
rounded-16) — this change targets height only.extensionlint (0 warnings), andHijackingLoginStrip.spec.tsx(13/13) all pass.🤖 Generated with Claude Code
Preview domain
https://fix-hijacking-cta-arm-height.preview.app.daily.dev