Repository navigation
Release owned MLX model and tokenizer references on unload - #249
Merged
Merged
Conversation
daniele21
marked this pull request as ready for review
October 18, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and outcome
MLXEngine.close()was a no-op: even when Korgis logically unloaded a runtime, its backend could keep model/tokenizer references alive. Correct that root cause in the canonical MLX backend, ensuring idempotent close, closed-runtime inference rejection, and model-isolated teardown under lease-safe manager semantics.Invariants
Classification
PRODUCT_LOCAL / INTEGRATION / STRONG (native runtime lifecycle and resources) / REMOTE_AUTOMATED deterministic, REAL_ENVIRONMENT 32-GiB Apple Silicon reclamation pending #239 and #244.
Evidence
Deterministic tests verify weakref release, repeated close, closed stream, busy-lease protection and unrelated MLX model retention. Required CI and base revalidation before merge.
Exact-head validation
82466a4a815f8e1f8967cf1a55dccd765c9c5e83/ converged dev baseeb8cfdbe5eb32a72102d26189f60555cf3f80728.