Conversation
To avoid leaking container children during reintegration, perform
container recovery in all reintegration modes. Not addressed by this
simple change is the extra delay for a POOL_REINT request.
Fix the backoff-less retrying of -DER_AGAINs from container recovery. It
has been seen to generate 11 million log messages within 2 minutes.
Fix an ilog_modify log message that can't be controled by DD_MASK,
making it unnecessarily harder to turn on debug messages.
Fix segfault
#0 crt_hg_bulk_transfer at src/cart/crt_hg.c:2253
#1 crt_bulk_transfer at src/cart/crt_bulk.c:306
#2 ds_pool_recov_cont_handler at src/pool/srv_target.c:3203
#3 crt_handle_rpc at src/cart/crt_rpc.c:1756
that happens when reintegrating a target on the PS leader, likely caused
by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing
bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk
transfers is not addressed by this fix.)
Signed-off-by: Li Wei <liwei@hpe.com>
Restore the pre-#18651 behavior that aborts a pool reintegrate operation upon unknown target. Test-tag: pr rebuild dmg_negative_test Signed-off-by: Li Wei <liwei@hpe.com>
|
Ticket title is 'Rebuild and container IV activities may result in orphan container children' |
liw
marked this pull request as ready for review
September 16, 2026 01:56
Nasf-Fan
approved these changes
Sep 16, 2026
Contributor
Author
|
We'll also need to add a backport of #19106 here. |
liuxuezhao
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid leaking container children during reintegration, perform
container recovery in all reintegration modes. Not addressed by this
simple change is the extra delay for a POOL_REINT request.
Fix the backoff-less retrying of -DER_AGAINs from container recovery. It
has been seen to generate 11 million log messages within 2 minutes.
Fix an ilog_modify log message that can't be controled by DD_MASK,
making it unnecessarily harder to turn on debug messages.
Fix segfault
that happens when reintegrating a target on the PS leader, likely caused
by NULL crt_rpc_priv.crp_hg_hdl. The approach is to use the existing
bulk mechanism offered by CaRT for CoRPCs. (The CaRT bug with local bulk
transfers is not addressed by this fix.)
Restore the pre-#18651 behavior that aborts a pool reintegrate operation upon unknown target.
Test-tag: pr rebuild dmg_negative_test
Steps for the author:
After all prior steps are complete: