SRE-3930 ci: Retry SCM notifications without failing the build - #532
Merged
Merged
Conversation
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
grom72
requested changes
Sep 3, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
marked this pull request as ready for review
September 3, 2026 14:09
…rove-github-notify
janekmi
requested changes
Sep 10, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
requested changes
Sep 11, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
requested changes
Sep 15, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
previously approved these changes
Sep 17, 2026
grom72
previously approved these changes
Sep 18, 2026
ryon-jensen
reviewed
Sep 21, 2026
|
|
||
| try { | ||
| scmNotifyTrusted(config) | ||
| } catch (Exception e) { |
Collaborator
There was a problem hiding this comment.
What would happen if the build is canceled by user during the sleep? Do we need something like this?
} catch (org.jenkinsci.plugins.workflow.steps.FlowInterruptedException e) {
throw e
} catch (InterruptedException e) {
throw e
} catch (Exception e) {
echo "ERROR: could not notify GitHub after ${notifyAttempt} attempts " +
"(${e.message}); continuing because status notification is non-fatal."
}
Contributor
Author
There was a problem hiding this comment.
Good point. I added explicit handling for InterruptedException. Since Jenkins' FlowInterruptedException is a subclass of it, this also covers user cancellation during sleep without requiring Jenkins-specific imports in the unit test.
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.