Skip to content

feat(ime): remember dock/float choice across keyboard shows #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willwade merged 1 commit into from
Sep 18, 2026
Merged

feat(ime): remember dock/float choice across keyboard shows #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 38 additions & 10 deletions app/src/main/java/at/dasher/android/DasherImeService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,19 @@ class DasherImeService : InputMethodService() {
// Floating mode
private var floating = false
private var floatingView: LinearLayout? = null
private var floatDockBtn: Button? = null

// Last-used mode (dock/float), restored on the next keyboard show so
// the IME opens where the user left it (Heide: "start it directly as
// docked, like other keyboards do"). Docked is the default.
private val imePrefs get() = getSharedPreferences("dasher_ime", MODE_PRIVATE)

private fun saveStartMode(floatingNow: Boolean) {
imePrefs.edit().putString("start_mode", if (floatingNow) "floating" else "docked").apply()
}

private fun startModeIsFloating(): Boolean =
imePrefs.getString("start_mode", "docked") == "floating"

// The docked root's parent is a FrameLayout inside the IME window's
// decor. setLayoutParams performs NO type conversion — LinearLayout
Expand Down Expand Up @@ -143,15 +156,27 @@ class DasherImeService : InputMethodService() {
setDockedHeight(imeHeightPx())
root.minimumHeight = imeHeightPx()

floatBtn.setOnClickListener { enterFloatingMode(floatBtn) }

Handler(Looper.getMainLooper()).post { createEngine() }
floatDockBtn = floatBtn
floatBtn.setOnClickListener { enterFloatingMode() }

Handler(Looper.getMainLooper()).post {
createEngine()
// Restore the user's last mode. Only when the overlay permission
// is already granted — without it enterFloatingMode would bounce
// the user to system settings on every keyboard show (the
// permission prompt belongs to an explicit Float tap).
if (startModeIsFloating() &&
android.provider.Settings.canDrawOverlays(this)
) {
enterFloatingMode()
}
}
return root
}

// ── Floating mode ──────────────────────────────────────────────────────

private fun enterFloatingMode(floatBtn: Button) {
private fun enterFloatingMode() {
if (floating) return
// Floating mode draws over other apps (TYPE_APPLICATION_OVERLAY) —
// a special-app-access permission the user must grant. Without it
Expand Down Expand Up @@ -252,8 +277,9 @@ class DasherImeService : InputMethodService() {
// FrameLayout.LayoutParams: the docked root's parent is the window's
// FrameLayout decor — LinearLayout.LayoutParams crash on re-measure.
setDockedHeight(dp(40, density))
floatBtn.text = "Dock"
floatBtn.setOnClickListener { exitFloatingMode(floatBtn) }
saveStartMode(true)
floatDockBtn?.text = "Dock"
floatDockBtn?.setOnClickListener { exitFloatingMode() }

// Drag handling. Gravity.TOP or Gravity.LEFT — LEFT is explicit;
// START can resolve to RIGHT on Samsung (overlay windows), inverting
Expand All @@ -279,7 +305,7 @@ class DasherImeService : InputMethodService() {
}
}
// Also wire the dock button.
dockBtn.setOnClickListener { exitFloatingMode(floatBtn) }
dockBtn.setOnClickListener { exitFloatingMode() }

// Resize handling (#49): drag the ⟷ handle to adjust the floating
// window's width (height follows proportionally). Pin the handle's
Expand Down Expand Up @@ -314,7 +340,7 @@ class DasherImeService : InputMethodService() {
canvasView?.let { if (it.width > 0 && it.height > 0) engine?.onSurfaceSizeChanged(it.width, it.height) }
}

private fun exitFloatingMode(floatBtn: Button) {
private fun exitFloatingMode() {
if (!floating) return
val fv = floatingView ?: return
try { windowManager.removeView(fv) } catch (_: Exception) {}
Expand All @@ -332,8 +358,9 @@ class DasherImeService : InputMethodService() {
setDockedHeight(imeHeightPx())
floatingView = null
floating = false
floatBtn.text = "Float"
floatBtn.setOnClickListener { enterFloatingMode(floatBtn) }
saveStartMode(false)
floatDockBtn?.text = "Float"
floatDockBtn?.setOnClickListener { enterFloatingMode() }
canvasView?.let { if (it.width > 0 && it.height > 0) engine?.onSurfaceSizeChanged(it.width, it.height) }
}

Expand Down Expand Up @@ -523,6 +550,7 @@ class DasherImeService : InputMethodService() {
canvasHost = null
loadingOverlay = null
dockedRoot = null
floatDockBtn = null
editingToolbar = null
super.onDestroy()
}
Expand Down
Loading