fix(identities): keep only the id of a former user on the catalogs of others - #34
Merged
Merged
Conversation
… others - bump @data-fair/lib-express to 1.26.0 (secret in the x-secret-key header) - delete: created/updated of catalogs, imports and publications only keep the id of a former user; the name is now optional in the schemas and the UI labels it "Ancien utilisateur" / "Former user" - dev: simple-directory calls the identities router directly, the shared router refuses calls that come through the proxy - identities.api.spec covers the renames (author, owner, department), the user deletion and the organization deletion
The shared identities router refuses the calls that come through the proxy, and the other services of the dev environment do not need the webhooks.
…t in the UI A department missing from the complete list sent by simple-directory was deleted: catalogs, imports and publications keep the department id but lose departmentName. The UI shows them as "Former department - <id>" (owner avatar, activity, owner filters). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017hqsZKwijEBoB3m3v9srVD
…n messages The production build uses the runtime-only vue-i18n: inline messages given to useI18n are not compiled and the key was displayed instead of the label. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017hqsZKwijEBoB3m3v9srVD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-service pass of the identities contract work, guided by the
data-fair-identitiesskill of the lib.@data-fair/lib-expressto 1.26.0 (secret accepted in thex-secret-keyheader)departmentslist sent by simple-directory was deleted; its catalogs, imports and publications keep the department id but losedepartmentName; the UI labels it "Ancien département - " / "Former department - " (owner avatar tooltip, owner filters, activity)created/updatedof catalogs, imports and publications only keep the id of a former user; the name is now optional in the schemas and the UI shows "Ancien utilisateur" / "Former user" when it is absenttests/features/catalogs/identities.api.spec.ts: renames (author, owner, department), department deletion, user deletion, organization deletionWhy: GDPR — a deleted user's name survived on the catalogs of others, and a deleted department kept showing under its old name.