chore(ui): stop committing the generated dts files - #160
Merged
Merged
Conversation
They are written by the vite plugins (router, auto-imports, components) and churned between dev and build (the /dev page only exists in dev). The ui build no longer runs vue-tsc before vite, the type check runs after the build as in the other data-fair services. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop tracking
ui/dts/*(typed router, auto-imports, components): they are generated by the vite plugins, like in data-fair, portals and catalogs.ui/dtsis ignored inui/.gitignorebuildscript is now plainvite build(it ranvue-tsc -bfirst, which is why the generated files had to be committed)npm run qualityWhy: the files churned between dev and build (the
/devpage only exists in dev) and polluted unrelated diffs.Heads-up: on a fresh clone,
npm run check-typesneeds a ui build or a dev server run first to generateui/dts, same as data-fair. The docker image builds and serves the SPA without the files.