Honor transaction: false hooks - #1679
Open
gauravshirore96 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gaurav Shirore <shiroregaurav2@gmail.com>
gauravshirore96
requested review from
jprakash-db,
saishreeeee and
sd-db
as code owners
September 12, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1549
Description
Databricks does not support the transaction semantics used by dbt-core's
default
run_hooksmacro.Previously,
transaction: falsehooks were silently skipped on the V1materialization path, while the V2 path could fail with
NO_ACTIVE_TRANSACTIONbecause dbt-core emits an explicitCOMMIT.This change overrides
run_hooksfor Databricks so that hooks are executedin a single pass without transaction filtering or an explicit
COMMIT.The V1 and V2 pre/post-hook paths now execute hooks consistently.
Testing
tests/unit/macros: 263 passedtests/unit: 1350 passed, 4 skipped, 1 unrelated failure due to missing Node.jshttp_path.Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.dbt-databricks-pr-readyproject skill for this PR and addressed its merge-readiness feedback