Repository navigation
Skip credentialed integration jobs on fork PRs - #1043
Merged
Merged
Conversation
david-siqi-liu
requested review from
AarushiShah-db,
lilly-luo and
rohita5l
as code owners
October 8, 2026 14:58
david-siqi-liu
force-pushed
the
david/ci-skip-windows-oidc-on-forks
branch
from
October 8, 2026 15:03
62025d5 to
bcea51f
Compare
david-siqi-liu
changed the title
david-siqi-liu
force-pushed
the
david/ci-skip-windows-oidc-on-forks
branch
2 times, most recently
from
October 8, 2026 15:09
062fc7d to
5f3c41e
Compare
The job logs in to JFrog with a GitHub OIDC token, which pull requests from forks never receive, so it failed on every fork PR. Guard it like the other credentialed integration jobs. The contract test now lists the integration jobs that skip fork PRs, checks that against the workflow, and rejects secrets or OIDC in any job that runs on forks. Co-authored-by: Isaac <no-reply@databricks.com>
david-siqi-liu
force-pushed
the
david/ci-skip-windows-oidc-on-forks
branch
from
October 8, 2026 15:11
5f3c41e to
3ddfb5e
Compare
masonc08
approved these changes
Oct 8, 2026
rohita5l
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows installation testslogs in to JFrog with a GitHub OIDC token (id-token: write). Pull requests from forks never get one, so the job failed on every fork PR (for example #901: "Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable").Add the same fork guard the other credentialed integration jobs use.
Make the fork rule explicit in
tests/test_integration_contract.py. It listsSKIPPED_ON_FORK_PRSand derives each job's real fork behavior from the workflow, through its own guard or a skippedneeds. The test fails if:Dropping the new guard fails the test.
Follow-up from the same thread, not in this PR: a way for fork PRs to run the credentialed suites after a team member approves or adds a label.
This pull request and its description were written by Isaac.