Repository navigation
[test, do not merge] Fork integration check on #1017 - #1045
Closed
david-siqi-liu wants to merge 2 commits into
Closed
david-siqi-liu wants to merge 2 commits into
david-siqi-liu wants to merge 2 commits into
Conversation
…owser re-auth A ug claude launch calls get_databricks_token from many places, and a host whose first-matching CLI profile has a stale refresh token paid fail -> auth login --no-browser -> fail on every call. Current CLIs reject --no-browser, so the re-auth never did anything. Memoize tokens per workspace and resolved profile until five minutes before their earliest stated expiry, or for 60 seconds without expiry. Cache definitive failures briefly, but never cache token-fetch or re-auth timeouts and lock contention. Forced refresh bypasses the memo and does not replace a success with failure. Auth validation shares successful tokens and logins clear the memo. Only attempt non-interactive re-auth when the CLI advertises --no-browser, and skip the second fetch after a failed re-auth. Ported from databricks-eng/universe#2742026 onto Unity Gateway main at 4d8ff8d. Coordinate concurrent fetches per key, reject in-flight memo writes after login invalidation, and cover failed help probes, expiry, refresh, and concurrent callers without changing credential/profile routing. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Harry Yao <harry.yao@databricks.com>
Require explicit invalid or missing credential diagnostics before negative caching, expire memos when either wall or monotonic time reaches its deadline, and clear the shared token memo after every attempted MCP connection login. Add regressions for transient failure recovery, suspend and clock rollback, login failure paths, and fresh-token use on sync and async proxy retries. Update the component coverage notes. Signed-off-by: Harry Yao <harry.yao@databricks.com>
david-siqi-liu
marked this pull request as ready for review
October 8, 2026 15:26
david-siqi-liu
marked this pull request as draft
October 8, 2026 15:28
Collaborator
Author
|
Closing: pull_request_target only runs main's workflow file, so this mirror cannot exercise #1044 before it merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test only, do not merge. Mirrors the head of #1017 from a fork, based on #1044, to exercise the fork integration approval flow end to end. I will close it after the run.
This pull request and its description were written by Isaac.