Repository navigation
consolidate smart routing configuration env vars into SMART_ROUTER_CONFIG - #1051
Merged
Merged
Conversation
lilly-luo
changed the title
lilly-luo
changed the title
lilly-luo
commented
Oct 8, 2026
lilly-luo
commented
Oct 8, 2026
UG reviewReviewed preset precedence, CLI environment restoration, managed routing defaults, and session/orchestrator flag resolution, along with the supplied retry and transcript-evidence changes. No actionable regression is evident in the supplied patch. No actionable findings.
Automated advisory review of |
# Conflicts: # tests/README.md
lilly-luo
enabled auto-merge
October 9, 2026 05:22
Unrouted Claude sessions stay in auto mode, and their classifier requests through the recording proxy raise an informational modal that blocked the parent turn until the 240s timeout. Continue past that exact notice once. Co-authored-by: Isaac <no-reply@databricks.com>
Wait for billing-notice input readiness and confirm dismissal instead of leaving a visible notice blocked after the first Enter. Correlate native peer hand-backs with successful Agent spawns so the final parent answer remains in the requested turn. Accept only Claude child requests' single transport newline after the routing checkpoint. Add PTY and negative evidence regressions and update coverage docs.
Claude 2.1.290 retains finished children in a Completed task list instead of showing the empty task view. Accept only a fully rendered native menu whose completed count matches its checkmarked done rows, then observe menu dismissal before submitting /exit. Continue waiting for running or scheduled tasks. Cover empty/completed views and negative controls with the offline PTY regression and update the testing coverage docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEFORE: you had to set a million environment variables in order to configure smart routing. this is not scalable as we continue to add more configurations:
ENABLE_SMART_ROUTING_V2=1, ENABLE_SMART_ROUTING_SUBAGENT_ONLY, ENABLE_SMART_ROUTING_ORCH.
AFTER: instead, we will have an env var SMART_ROUTING_CONFIG=subagent_only_v1, subagent_only_v2, and then do the resolution of the config into diff env vars to preserve the behavior. that way, the call site only needs to pass in:
SMART_ROUTING_CONFIG=subagent_only_v1 ug to get the appropriate configuration.
testing:
ENABLE_SMART_ROUTING_V2=1 && ENABLE_SMART_ROUTING_SUBAGENT_ONLY=1 uv run ug claudeis same asSMART_ROUTER_CONFIG_VERSION=subagent_only_v1 SMART_ROUTER_NAME=m2-r315-quality-20260929 uv run ug claude(what we have in isaac)ENABLE_SMART_ROUTING_V2=1 && ENABLE_SMART_ROUTING_SUBAGENT_ONLY=1 && ENABLE_SMART_ROUTING_ORCH=1 uv run ug claudeis same asSMART_ROUTER_CONFIG_VERSION=subagent_orch_v1 SMART_ROUTER_NAME=m2-r315-quality-20260929 uv run ug claude(what we have in isaac)ENABLE_SMART_ROUTING_V2=1 uv run ug claudeis same asSMART_ROUTER_CONFIG_VERSION=first_prompt_and_subagent_no_orch_v0 uv run ug claude(what customers will have)the recipe name is a separate env var because we want to be able to change the recipe without needing to update ug