Fix Permitted Value for Expression Type Rules - #36
Conversation
GeekSheikh
left a comment
There was a problem hiding this comment.
@goodwillpunning Do we have any tests on the output reports? I didn't see any changes to tests that change the actual/permitted values. Did I just miss them?
| lit(rule.ruleName).alias("ruleName"), | ||
| (rule.inputColumn === rule.validExpr).alias("passed"), | ||
| lit(rule.inputColumnName).alias("permitted"), | ||
| rule.inputColumn.cast("string").alias("permitted"), |
There was a problem hiding this comment.
Here I was expecting there to be the following columns.
ruleName - good
passed - good
logic - not present. This should be the SQL expr used to derive the "permitted"
permitted - allowed value or range
actual - the result of the expression value
|
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This commit corrects a display-only bug in the validation results when expression type Rules are used. Previously, the
permittedcolumn would display the Rule expression as a String. This commit updates thepermittedcolumn to the evaluated expression.This commit also removes an unused object,
Lookups.