Feature/poi support - #79
Draft
adefabian wants to merge 9 commits into
Draft
Conversation
ran update-api-docs
Added missing poi in Source Basemodel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Points-in-Time (POI) series as a first-class silver-layer channel type:
a value defined only at its timestamp (no between-point validity), backed by
PointsInTimeSeries, sitting alongside the existing interval-valuedSampleSeries.The motivating case is ECU Diagnostic Trouble Codes (DTCs) — string-valued fault
events analyzed together with continuous signals ("RPM at the instant
DTC == P0301").Changes
poi_channelssilver table (POI_CHANNELS_SCHEMA); series type isdetermined by table membership (
channels⇒ SAMPLE,poi_channels⇒ POI) — noseries_typecolumn needed.PointsInTimeSeriesgains string-value support —==/!=and samplingfor strings; arithmetic/ordering/reductions raise for strings via a
@_numeric_onlyguard; value-type-aware
dtype().QueryBuilder.poi_channel(dtype=...)(accepts the enum or the plainstring
"double"/"string"); the selector carriesseries_type+value_typeandis the plan-time source of truth for series-type dispatch.
_prepare_channels_joinunionspoi_channelsafter RLE encoding(zero-duration points aren't merged);
TimeSeriesCache.load_blobbuilds the rightseries from the selector; a solve-time assertion rejects a declared-vs-actual mismatch.
poi_channels_uriwired throughMeasurementDBConfig,MeasurementDB.poi_channels(), and the reportingSourceconfig.mix-and-match, declared-vs-actual, backward-compat),
PointsInTimeSeriesstringunits,
poi_channel(dtype=...)coercion units, and a config-passthrough regression.reporting_pipeline.ipynbgains a DTC section — freeze-frame (RPM at eachP0301 misfire), per-recording fault counts, and a ±10 s window histogram around faults.
make update-api-docstarget added.Test Plan
Checklist