Repository navigation
fix(support): external multi-anno restituisce lista URL, non glob - #493
Merged
Merged
Conversation
- support.py: _resolve_external_entry produce lista URL risolti invece del glob (DuckDB non accetta glob su HTTP) - template.py: render_template formatta le liste come array SQL ['url1', 'url2'] per read_parquet nativo - test: multi_year_uri ora aspetta lista, non glob
Review PR #493: - test_template.py: 4 nuovi test (lista→array SQL, empty list, stringa invariata, dataset multi-anno resta stringa) - test_support.py: asserzione isinstance(clean, str) per dataset multi-anno (regressione) - support.py: docstring aggiornata (clean = lista, non glob) - ADR-005 / config-schema.md / conventions.md: documentato il tipo di {support.NAME.clean} per external multi-anno
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Fix per support external multi-anno: DuckDB non accetta glob su HTTP.
_resolve_external_entryproduceva un glob perclean, che falliva conread_parquet('{support.NAME.clean}'). Ora produce una lista URL che il renderer SQL formatta come array DuckDB.Contesto collegato
Consumer:
terzo-settore— compose ETS che consumano fonti external multi-anno da GCS (anac_bandi_gara, fts_eu_grants, rna_aiuti_stato).Cosa cambia
Impatto su contratti pubblici
dataset.yml—{support.NAME.clean}per external multi-anno cambia tipo:str (glob)→list[URL]render_templategestisce le liste come array SQLVerifica
Note per chi revisiona
type: datasetmulti-annocleanresta stringa (glob locale) — invariato, testatotype: externalsingle-annopathresta template URI — invariatosupport.pyè il pezzo critico;template.pyprotegge il rendering SQL delle liste