docs(deploy): note set_replica_identity partial-failure semantics#193
Open
dimitri-yatsenko wants to merge 1 commit into
Open
docs(deploy): note set_replica_identity partial-failure semantics#193dimitri-yatsenko wants to merge 1 commit into
dimitri-yatsenko wants to merge 1 commit into
Conversation
The spec omitted the failure mode: tables are altered one at a time, so a mid-run error leaves earlier ALTERs committed and returns no summary. Matches the behavior documented in deploy.py's docstring. Re-run to converge.
MilagrosMarin
approved these changes
Jul 1, 2026
MilagrosMarin
left a comment
MilagrosMarin
left a comment
Collaborator
There was a problem hiding this comment.
Matches deploy.py's "Partial-failure semantics" docstring on master exactly, and closes the spec-vs-implementation gap from my #1466 review point #7. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line addition to the
set_replica_identityspec (deploy-operations.md), following the #1466 implementation landing ondatajoint-pythonmaster.The spec's Behavior section documented idempotency but omitted the failure mode: the operation is not atomic — tables are altered one at a time, so if execution raises on table N of M, the first _N_−1 ALTERs have already committed and the exception propagates without returning a summary. This matches the behavior already documented in
deploy.py's docstring; re-running converges since each ALTER is idempotent.Surfaced during a spec-vs-implementation consistency check of datajoint/datajoint-python#1466.