Skip to content

feat: DM-4759 model the unlicensed features a ruleset uses - #49

Merged
cph-datamasque merged 1 commit into
epic/DM-4744-foundation-structured-limitsfrom
DM-4759-license-warnings
Sep 24, 2026
Merged

cph-datamasque merged 1 commit into
epic/DM-4744-foundation-structured-limitsfrom
DM-4759-license-warnings

Conversation

@cph-datamasque

@cph-datamasque cph-datamasque commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Adds unlicensed_feature_warnings to Ruleset: one sentence per feature the ruleset uses that the server's licence does not allow.

It is empty when the ruleset needs nothing its licence withholds, and None until the ruleset has passed validation — which is not the same as having no warnings, and the tests pin that distinction.

Requires server version 3.26.18, which is where DM-4759 lands.

Comment thread tests/test_rulesets.py Outdated
@carlosfunk

Copy link
Copy Markdown
Member

datamasque/client/models/ruleset_library.py is not in the diff, so this cannot go on a line.

The server now also returns unlicensed_feature_warnings on libraries.
The ticket asks for the affected SDK types to be updated.
Add the field to RulesetLibrary, and populate it in create_ruleset_library and the update path, as Ruleset does.
Add a test.

@cph-datamasque
cph-datamasque changed the base branch from main to epic/DM-4744-foundation-structured-limits September 23, 2026 23:55
@cph-datamasque
cph-datamasque force-pushed the DM-4759-license-warnings branch from 99fa2bf to 1b96c43 Compare September 24, 2026 00:15
@cph-datamasque
cph-datamasque merged commit 0168ff7 into epic/DM-4744-foundation-structured-limits Sep 24, 2026
@cph-datamasque
cph-datamasque deleted the DM-4759-license-warnings branch September 24, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants