Skip to content

chore(indexers): updated vectorstore types - #143

Open
rileyok-ons wants to merge 9 commits into
mainfrom
142-update-vectorstore-types
Open

rileyok-ons wants to merge 9 commits into
mainfrom
142-update-vectorstore-types

Conversation

@rileyok-ons

@rileyok-ons rileyok-ons commented Mar 6, 2026 •

Copy link
Copy Markdown
Contributor

✨ Summary

Fixes the typing for vectorstore to add typehints to the methods and resolve type errors with internal .vectors
Also fixes bug with deptry on pre-commit hook
Also updates server pydantic models to patch out deprecated extra definition (now uses configdict)
Resolves #142

📜 Changes Introduced

  • adds in correct entrypoint for deptry in pre-commit docker

  • adds proper init typehints for vectorstore

  • adds support for pathlike for filename inputs

  • Feature implementation (feat:) / bug fix (fix:) / refactoring (chore:) / documentation (docs:) / testing (test:)

  • Updates to tests and/or documentation

  • Terraform changes (if applicable)

✅ Checklist

Please confirm you've completed these checks before requesting a review.

  • Code passes linting with Ruff
  • Security checks pass using Bandit
  • API and Unit tests are written and pass using pytest
  • Terraform files (if applicable) follow best practices and have been validated (terraform fmt & terraform validate)
  • DocStrings follow Google-style and are added as per Pylint recommendations
  • Documentation has been updated if needed

🔍 How to Test

Run usual demo to check if it inits correctly, then try inputting in Path as file location, check if intellisense looks better

@rileyok-ons
rileyok-ons requested a review from a team as a code owner March 6, 2026 16:20
@rileyok-ons rileyok-ons linked an issue Mar 6, 2026 that may be closed by this pull request
@github-actions github-actions Bot added the chore label Mar 6, 2026

@frayle-ons frayle-ons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small change requested - and can we confirm this will work okay with quartodocs.

Comment thread src/classifai/indexers/main.py Outdated
Comment thread src/classifai/indexers/main.py Outdated
@lukeroantreeONS

Copy link
Copy Markdown
Contributor

This all looks good to me - but before merging, can we check that initialising a VectorStore with a CSV within a GCP Bucket still works with the new checks added? (I know we haven't advertised that functionality yet, but it would be a shame to break it)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update VectorStore types

3 participants