chore(indexers): updated vectorstore types - #143
Open
rileyok-ons wants to merge 9 commits into
Open
rileyok-ons wants to merge 9 commits into
rileyok-ons wants to merge 9 commits into
Conversation
frayle-ons
requested changes
Mar 9, 2026
frayle-ons
left a comment
Contributor
There was a problem hiding this comment.
LGTM, one small change requested - and can we confirm this will work okay with quartodocs.
Contributor
|
This all looks good to me - but before merging, can we check that initialising a VectorStore with a CSV within a GCP Bucket still works with the new checks added? (I know we haven't advertised that functionality yet, but it would be a shame to break it) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
Fixes the typing for vectorstore to add typehints to the methods and resolve type errors with internal
.vectorsAlso fixes bug with deptry on pre-commit hook
Also updates server pydantic models to patch out deprecated extra definition (now uses configdict)
Resolves #142
📜 Changes Introduced
adds in correct entrypoint for deptry in pre-commit docker
adds proper init typehints for vectorstore
adds support for pathlike for filename inputs
Feature implementation (feat:) / bug fix (fix:) / refactoring (chore:) / documentation (docs:) / testing (test:)
Updates to tests and/or documentation
Terraform changes (if applicable)
✅ Checklist
terraform fmt&terraform validate)🔍 How to Test
Run usual demo to check if it inits correctly, then try inputting in Path as file location, check if intellisense looks better