Repository navigation
✨ Add a textual-auto theme that follows the terminal - #158
Closed
WassimKallel wants to merge 1 commit into
Closed
WassimKallel wants to merge 1 commit into
WassimKallel wants to merge 1 commit into
Conversation
textual-auto looks like textual-light or textual-dark depending on the terminal's background. The background is queried with OSC 11 before Textual takes over the terminal, and changes are followed live in terminals that support colour scheme reports (DEC mode 2031). Also apply --theme even when the configuration has no theme saved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
As I glance over this, I feel this is a PR that's better made to Textual itself, for the benefit of all Textual applications, rather than being added to one random application that happens to be built using Textual. |
Author
|
You are right, |
Owner
|
Glad we agree. Nice enough idea but a bit too specific (and also leans into internals by the looks of it) for Hike itself. Probably better to advocate for Textual itself acquiring the ability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new theme
textual-auto, it looks like textual-light or textual-dark depending on the terminal's background. The background is queried with OSC 11 before Textual takes over the terminal, and changes are followed live in terminals that support colour scheme reports (DEC mode 2031).Note to the maintainer
PR was made with AI