Repository navigation
Strengthen verification tests and add the ASD test-audit workflow - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification tests previously fixed independent checks to an incidental total order, repeated fixture-authored assertions, and let some negative cases fail before reaching their claimed guard. This change checks operation counts and required dependency edges, exercises lint through the public command, and isolates inventory, dynamic-prefix, and shard-identity rejection paths. It removes redundant assertions and unused support while retaining real installation, receipt, hook, subprocess, and coverage proof.
The supporting test-audit skill adapts OpenClaw's workflow to agentic software delivery (ASD), with evidence-based discovery and separate repair and review. It preserves blind specialist restrictions and requires separate authorization for production repairs. Executable code changes are confined to four verification test files; supporting changes are instructions, documentation, and a lesson. No non-test code, tooling, workflow, or configuration changes are included. Scope and audit evidence are recorded in TEST-AUDIT-002.
Validation: canonical PR verification selected Tier 5/full and passed all 25 steps: 1,940 tests passed (185 warnings; no failures or skips), with 3,421/3,421 statements and 902/902 branches across all 21 owned runtime files. Global and every package coverage are exactly 100%; no statements or branches are excluded or missing. The renewed focused run passed 391 tests in 437.94 s on Python 3.12.14, macOS 27.0 arm64. Targeted Black and
git diff --checkboth returned 0. The clean locked environment passed all 8 preflight steps, a receipt-reuse smoke test, and a compiled SciPy probe. The initial attempt retained 295 passes, 23 failures, and 73 errors; all 96 unsuccessful cases were classified as environment failures. No tests or gates were weakened to resolve them.A confirmed baseline product issue is deferred outside this test-only repair scope: the public metrics command rejects complete passed
pr,library,doctor, andreleasereceipts withUnknown receipt mode. A separate probe of this candidate’s real completedprreceipt reproduced exit 1. Controlled orchestration probes confirmed the other three modes; those fixtures establish compatibility only, not domain coverage. The independent reviewer classified this unchanged issue as outside the candidate and selected gate; it remains explicitly disclosed for a separate runtime repair.Current state
6ca7c16844ef0ebcc53bdaee7eb6db474ab39b75oncodex/test-audit-verification; unchanged baseb995f5843edbb9247cdb3d9c0b1b08c97010e02a; targetcodex-main. Established contract; no specialist checkpoint.python tools/verification.py pr --base origin/codex-mainselected Tier 5/global full scope and returned 0. All 25 steps passed; 1,940 tests passed; exact global/per-package 100% statement and branch coverage. Receipt digest:5b0c683169b02c88344ea17b4f878c007c2a5839e69c2d78f1f104dcc7172faa. Host: Python 3.12.14, macOS 27.0 arm64; all four domains measured freshly.