Only Publish Relevant Files, Update GH Actions, Fix Publint Hints - #72
Open
beeequeue wants to merge 3 commits into
Open
Only Publish Relevant Files, Update GH Actions, Fix Publint Hints#72beeequeue wants to merge 3 commits into
beeequeue wants to merge 3 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR limits what files are included in the published package to only
lib/,examples/, andindex.jssince those are the files relevant to users.I also added
"type": "commonjs"as it showed up in the publint hintsFinally I also added the newer, missing Node versions to the CI tests, and updated the GH action versions.
As for other potential improvements, bumping the minimum node version from 6 to 20 (current LTS version) would be okay we could convert the package to ESM (thanks to
require(esm)) instead of CJS, and use the native node test runner instead of tap!fastbenchcould also be replaced withmitata, a fantastic benchmarking library that helps minimize common issues with benchmarking JS codeThere's also
neostandard, which is an attempt at a successor forstandard