Skip to content

Only Publish Relevant Files, Update GH Actions, Fix Publint Hints - #72

Open
beeequeue wants to merge 3 commits into
davidmarkclements:mainfrom
beeequeue:best-practices
Open

Only Publish Relevant Files, Update GH Actions, Fix Publint Hints#72
beeequeue wants to merge 3 commits into
davidmarkclements:mainfrom
beeequeue:best-practices

Conversation

@beeequeue

Copy link
Copy Markdown

This PR limits what files are included in the published package to only lib/, examples/, and index.js since those are the files relevant to users.

I also added "type": "commonjs" as it showed up in the publint hints

Finally I also added the newer, missing Node versions to the CI tests, and updated the GH action versions.


As for other potential improvements, bumping the minimum node version from 6 to 20 (current LTS version) would be okay we could convert the package to ESM (thanks to require(esm)) instead of CJS, and use the native node test runner instead of tap!

fastbench could also be replaced with mitata, a fantastic benchmarking library that helps minimize common issues with benchmarking JS code

There's also neostandard, which is an attempt at a successor for standard

@beeequeue

Copy link
Copy Markdown
Author

@mcollina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant