Repository navigation
security: bump vitest 0.34.6 -> 4.1.11 (closes last critical) - #362
Merged
Merged
Conversation
… advisories Closes the last critical advisory in this repo: GHSA-82fw-gwwq-j7x9 Vitest: path traversal / arbitrary file read via the @vitest/mocker redirect mock. Fixed in 4.1.11. GHSA-5xrq-8626-4rwp Arbitrary file read and execution while the Vitest UI server is listening. A plain `npm install -D vitest@^4.1.11` fails here: vitest 4 declares a peer of @types/node ^20 || ^22 || >=24, and this repo pinned ^18.16.0, so npm aborts with ERESOLVE. Bumping @types/node to ^24 alongside it resolves cleanly. Both are devDependencies and neither is published -- `files` ships only dist/ and skills/. Also includes the lockfile-only fixes from `npm audit fix` (no --force). Verified, comparing against master rather than trusting a green run: - vitest 0.34.6 (master): 9 files failed, 33 tests failed, 174 passed - vitest 4.1.11 (this PR): 9 files failed, 33 tests failed, 174 passed Byte-identical. Those 33 failures are pre-existing and environmental -- they are live JSON-RPC calls returning "Must be authenticated!" because the RPC keys are not set locally. The bump regresses nothing. - `npm run build` (tsup) exits 0; ESM, CJS and DTS all emit. Result: 0 critical, 2 high (was 1 critical, 4 high). Remaining highs need semver-major upgrades: vite ^4.5.0 -> 8.x and ws via ethers 6.17.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last critical advisory in this repo, and picks up the non-breaking lockfile fixes from
npm audit fix(no--force).@vitest/mockerredirect mockWhy dependabot couldn't do this one
A plain
npm install -D vitest@^4.1.11fails here:vitest 4 requires
@types/node≥20 and this repo pinned^18.16.0. Bumping@types/nodeto^24alongside it resolves cleanly. Both are devDependencies and neither is published —filesships onlydist/andskills/.Verification
I compared against
masterrather than trusting a green run, because this suite does not pass cleanly either way:master)Identical. Those 33 failures are pre-existing and environmental — live JSON-RPC calls returning
Must be authenticated!because RPC keys aren't set locally. This bump regresses nothing.npm run build(tsup) exits 0; ESM, CJS and DTS all emit.Result
0 critical, 2 high (was 1 critical, 4 high). The 2 remaining highs need semver-major upgrades —
vite^4.5.0→ 8.x andwsviaethers6.17.0 — so they're left for a deliberate change.🤖 Generated with Claude Code