Repository navigation
Fix local-time scheduling across daylight saving changes - #201
Merged
Merged
Conversation
Build scheduled times from the team's timezone and calendar date instead of adding elapsed seconds to midnight. Share the conversion across rounds, next-round estimates, reminders and follow-ups, and cover spring/fall transitions with deterministic second-level boundaries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the DST scheduling failure exposed by dependency upgrade #200 in a separate, default-branch-based PR. No dependency or website changes.
Adding the configured number of seconds to local midnight measures elapsed time, not wall-clock time: on a DST transition day an 8:30 schedule can become 9:30 or 7:30. Add
Team#sup_time_onusing the timezone and calendar date, following the existing Sup2 implementation, and use it for round eligibility, next-round estimates, follow-ups, and reminders. Keep existing weekday, recurrence and elapsed-time guards intact.Add deterministic spring-forward and fall-back regressions, checking the exact configured hour/minute/second and the one-second-before boundary. Correct the shared team-spec time fixture so it does not reproduce the same midnight-arithmetic bug.
This is separate from #200 and can merge first; the upgrade branch can then pick up the fix.
Validation
Full RSpec suite: 550 examples, zero failures, four existing pending. Required RuboCop/autogenerated-baseline checks pass; no new exclusions or raised thresholds.
Authored by Copilot AI on behalf of @dblock.