fix: refresh dcc-bus after SSO and surface connect failures - #4
Merged
Conversation
The kiosk never called GET /layouts/{id}/presence, so dcc-bus programs
were not rebuilt after organizer login and a failed programming warm-up
was swallowed. Poll presence first, then connect, and show a retryable
banner when the socket is down.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/layouts/{id}/presence(already proxied to BigFred) before warming the programming WebSocket, so dcc-bus programs are rebuilt without opening the BigFred dashboard.connectProgramming()is no longer swallowed: the shell shows the error plus a retry button.Test plan
Made with Cursor