solution: add missing parallel_boards.cpp/.hpp to VS projects#222
Merged
zzcgumn merged 1 commit intoJul 3, 2026
Merged
Conversation
calc_tables.cpp and solve_board.cpp reference resolve_worker_count and parallel_all_boards_n from system/parallel_boards.cpp, but neither dds_native.vcxproj nor DDS.vcxproj compiles that file, so dds_native.dll fails to link with unresolved externals (and executables consuming the DDS static library fail the same way). Add the .cpp to both projects, and the .hpp to the header lists and filters files for consistency with the other system/ sources. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As noted in #139,
dds_native.dllfails to link out of the box on Windows:calc_tables.cppandsolve_board.cppreferenceresolve_worker_count/parallel_all_boards_nfromlibrary/src/system/parallel_boards.cpp, but neithersolution/dds_native.vcxprojnorsolution/DDS.vcxprojcompiles that file, producing unresolved externals (for the static library, the errors surface when linking consuming executables such as the example projects).This PR adds
parallel_boards.cppto the<ClCompile>lists of both projects, andparallel_boards.hppto the<ClInclude>lists and the.filtersfiles, matching how the otherlibrary/src/system/sources are registered.Note: the same fix is needed on the PR #216 branch, whose
dds_native.vcxprojhas the same omission.Testing
On Windows 11 with MSVC v143 (VS 2022), from a clean checkout of develop (5cb0fb1) plus this change:
msbuild solution\dds_native.vcxproj /p:Configuration=Release /p:Platform=x64links successfully (previously failed with LNK2019 unresolved externals).msbuild solution\DDS.vcxproj, thenhands.vcxprojandcalc_all_tables.vcxproj, all build and link successfully.dds_native.dllwas used in the three-way benchmark/correctness comparison reported in Merge DDSS into DDS V3 #139 (agrees with DDS 2.9 and ddss on all 20,000 table cells over 1000 deals).