Open
Add semicolon missing from PR 223 (two-percent-solution)#224
Conversation
The ASAN CI job was failing because PR #223 (Two percent solution) introduced a missing semicolon at the end of ab_search.cpp:884 in the make_3() function: posPoint->second_best[st].hand = thrp->rel[aggr].abs_rank[2][st].hand ^ missing ; This commit applies all of PR #223's changes (removing unnecessary static_cast<unsigned char>() wrappers and fixing indentation) with the missing semicolon corrected.
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job asan
Fix missing semicolon in make_3() causing ASAN/all CI build failure
Jul 3, 2026
tameware
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a compilation-breaking syntax error introduced in PR #223 and reapplies PR #223’s intended “two percent solution” cleanups: removing redundant casts and aligning formatting in a few hot-path solver routines.
Changes:
- Fixes the missing semicolon in
make_3()and aligns the winner/second-best assignment block formatting inab_search.cpp. - Simplifies
rel_rankindexing and cleans up indentation/whitespace inheuristic_sorting.cpp. - Removes redundant inner
static_cast<unsigned char>usage when indexingbit_map_rankinquick_tricks.cpp.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| library/src/ab_search.cpp | Fixes the make_3() compilation error and removes unnecessary casts in winner/second-best assignments. |
| library/src/heuristic_sorting/heuristic_sorting.cpp | Simplifies rel_rank indexing and fixes indentation/whitespace in weighting helpers. |
| library/src/quick_tricks.cpp | Removes redundant casts in bit_map_rank indexing for abs-rank lookups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #223 ("Two percent solution") introduced a missing semicolon on the last assignment in
make_3(), breaking compilation for all CI jobs (asan, tsan, build_and_test).This PR applies the full set of PR #223's intended changes with the bug corrected:
ab_search.cpp— Removestatic_cast<unsigned char>()wrappers from rank/hand assignments inmake_3()andmake_3_ctx(); fix indentation of themake_3()block to matchmake_3_ctx(); add the missing semicolon.heuristic_sorting.cpp— Simplify chained casts (static_cast<int>(static_cast<unsigned char>(rel_rank[...][...]))) to direct indexing (rel_rank[tpos.aggr[suit]][mply[k].rank]); fix misalignedif/else ifblocks; remove trailing whitespace.quick_tricks.cpp— Remove redundant innerstatic_cast<unsigned char>()from twostatic_cast<int>(static_cast<unsigned char>(...))patterns.