Skip to content

fix(weather): mark temperature matcher as cacheable #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igoramf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(weather): mark temperature matcher as cacheable #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions weather/matchers/temperature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ export interface Props {
temperature: Temperature | null;
}

/**
* The weather match is derived from the visitor's geo (Cf-Iplatitude /
* Cf-Iplongitude) and never from per-user identity, so it is safe to bake
* into cached HTML shared across visitors. Without this, any page using this
* matcher falls through to `Cache-Control: no-store` (see blocks/matcher.ts).
*/
export const cacheable = true;

/**
* @title Weather
* @description Target users based on specific temperature
Expand Down
Loading