Skip to content

fix(details): translate the OAuth connect button's default label - #6225

Closed
pedrofrxncx wants to merge 1 commit into
mainfrom
fix/oauth-authenticate-button-i18n-w3
Closed

fix(details): translate the OAuth connect button's default label#6225
pedrofrxncx wants to merge 1 commit into
mainfrom
fix/oauth-authenticate-button-i18n-w3

Conversation

@pedrofrxncx

@pedrofrxncx pedrofrxncx commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Bug found while working the MCP connections UI focus area (issue #5661).

OAuthAuthenticationState (apps/web/src/components/details/connection/settings-tab/index.tsx) defaults its button label to a hardcoded English string "Authenticate" when no buttonText prop is passed. This is exactly the path hit from SettingsTab (settings-tab/index.tsx:230), so any pt-br user who opens the settings tab of a connection requiring OAuth and hasn't authenticated yet sees an untranslated English button, breaking the i18n rule that all user-facing UI strings go through t().

Fix: added details.settingsTab.authenticate to both en/details.ts and pt-br/details.ts, and changed the component default to buttonText ?? t("details.settingsTab.authenticate") instead of a hardcoded string literal. The one existing caller that already passes an explicit buttonText (apps/web/src/components/details/tool.tsx) is unaffected.

To confirm: open a connection's Settings tab for a connection requiring OAuth while not authenticated, with pt-br language selected — the button now reads "Autenticar" instead of "Authenticate".

Checks run locally: bun run fmt, cd apps/web && bunx tsc --noEmit (clean), bunx oxlint on the three changed files (0 warnings/errors). Full CI validates the rest.


Summary by cubic

Localizes the OAuth authenticate button’s default label. Previously it defaulted to the hardcoded English "Authenticate" when no buttonText was provided; now it uses the i18n key "details.settingsTab.authenticate" so pt-br and other locales render correctly.

  • Add "details.settingsTab.authenticate" to apps/web/src/i18n/en/details.ts and apps/web/src/i18n/pt-br/details.ts.
  • Update OAuthAuthenticationState to use t("details.settingsTab.authenticate") only when buttonText is not provided; callers that pass buttonText are unchanged.
  • Verify: open a not-yet-authenticated OAuth connection’s Settings tab in pt-br; the button reads "Autenticar".

Written for commit e7f6d6c. Summary will update on new commits.

Review in cubic

@pedrofrxncx

Copy link
Copy Markdown
Collaborator Author

Closing as stale: this PR sat past the bot's 48h merge window, main has moved on, and its CI results no longer reflect the current base. This is a housekeeping close, not a rejection of the change — if the underlying problem still exists, the bot will find it again and open a fresh, rebased PR.

[studio-bot:stale-close]

@pedrofrxncx
pedrofrxncx deleted the fix/oauth-authenticate-button-i18n-w3 branch August 31, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant