fix(task-board): don't stomp a human reassignment when un-delegating a column-rule claim

[pedrofrxncx]

Follows #6800 (runColumnAutomation), which introduced the shared column-rule claim path both the Jira sync and a manual drag now go through.

Bug: runColumnAutomation() claims an unassigned card for the Super Agent with a conditional UPDATE (WHERE assignee_id IS NULL), then calls reactToSuperAgentDelegation(), which can take a while (dispatch/quota check) or throw TaskQuotaError. On that throw it un-delegated with a plain update({ assigneeId: null, assignedBy: null }) — unconditional. If a human reassigned the card in that window (e.g. via TASK_BOARD_ITEM_UPDATE, in the gap between the claim and the quota check), this write silently wiped their reassignment back to null, losing the human's edit.

Fix: storage.taskBoard already has the right primitive for exactly this race — unassignSuperAgent(), a conditional UPDATE (WHERE assignee_id = SUPER_AGENT_ASSIGNEE_ID) already used by handTaskToHuman() to solve the identical problem (see its doc comment: "a plain update() would stomp that human's reassignment back to null"). Swapped the plain update() for it in run-column-automation.ts too, so un-delegation only takes effect if the card is still assigned to the Super Agent; otherwise it leaves the human's reassignment alone.

Failure scenario: column rule claims card X for the Super Agent → dispatch is mid-flight and the org's quota is exhausted → a teammate manually reassigns X to themselves in the meantime → the quota rejection's un-delegate write lands after and clobbers the teammate's assignment back to unassigned, silently losing their action.

How a reviewer confirms: rg unassignSuperAgent apps/api/src/tools/task-board — both call sites (run-reactions.ts's handTaskToHuman, and now run-column-automation.ts) share the same conditional fence and doc-comment rationale.

Checks run locally: bun run fmt, cd apps/api && bunx tsc --noEmit (clean), bunx oxlint apps/api/src/tools/task-board/run-column-automation.ts (0 warnings/errors). No new test: this reuses unassignSuperAgent(), an existing storage primitive already exercised by handTaskToHuman()'s integration coverage — this sandbox has no Postgres to add a new DB-backed test, and the fix is a one-line swap onto an already-tested method. Full CI validates the integration suite.

---

Summary by cubic

Fixes a race where un-delegating a column-rule claim could overwrite a human's concurrent reassignment, reusing the conditional unassignSuperAgent() primitive instead of a plain update.

• On a lost fence, re-reads the card before returning so the response doesn't render the human's reassignment as reverted.
• The conditional un-delegate now also clears assignedBy, fixing stale delegation metadata on unassigned cards (also on the handTaskToHuman path).
• Adds a real-Postgres integration test covering both the winning clear and the lost-fence case.

^{Written for commit 325903a. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/api/src/tools/task-board/run-column-automation.ts">

<violation number="1" location="apps/api/src/tools/task-board/run-column-automation.ts:77">
P2: When the quota rejection unassigns a card, the new helper clears only `assigneeId` and leaves `assignedBy` from the failed delegation. Preserve the conditional fence but also clear `assigned_by` in the successful `unassignSuperAgent()` update so unassigned cards do not retain stale delegation metadata.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: When the quota rejection unassigns a card, the new helper clears only assigneeId and leaves assignedBy from the failed delegation. Preserve the conditional fence but also clear assigned_by in the successful unassignSuperAgent() update so unassigned cards do not retain stale delegation metadata.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/tools/task-board/run-column-automation.ts, line 77:

<comment>When the quota rejection unassigns a card, the new helper clears only `assigneeId` and leaves `assignedBy` from the failed delegation. Preserve the conditional fence but also clear `assigned_by` in the successful `unassignSuperAgent()` update so unassigned cards do not retain stale delegation metadata.</comment>

<file context>
@@ -73,12 +73,13 @@ export async function runColumnAutomation(
     );
-    return await ctx.storage.taskBoard.update(
+    // Same conditional fence as `handTaskToHuman` — never stomp a concurrent reassignment.
+    const undelegated = await ctx.storage.taskBoard.unassignSuperAgent(
       item.id,
       orgId,
</file context>