Skip to content

fix(task-board): advance repo-less cards using the board's own review lane #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrofrxncx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(task-board): advance repo-less cards using the board's own review lane #6849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions apps/api/src/storage/task-board.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,7 @@ export class TaskBoardStorage {
taskId,
organizationId,
item.updatedBy,
lanes,

@cubic-dev-ai cubic-dev-ai Bot Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: On an org-owned board whose progress key is not in_progress, this call never reaches the lane-aware update because shouldAdvanceToReview rejects the item first. Make the eligibility check compare the card status with lanes.progress while preserving its existing thread and PR checks.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/storage/task-board.ts, line 1443:

<comment>On an org-owned board whose progress key is not `in_progress`, this call never reaches the lane-aware update because `shouldAdvanceToReview` rejects the item first. Make the eligibility check compare the card status with `lanes.progress` while preserving its existing thread and PR checks.</comment>

<file context>
@@ -1440,6 +1440,7 @@ export class TaskBoardStorage {
         taskId,
         organizationId,
         item.updatedBy,
+        lanes,
       );
       if (!advanced) continue;
</file context>

);
if (!advanced) continue;
moved.push(advanced);
Expand All @@ -1449,7 +1450,7 @@ export class TaskBoardStorage {
taskBoardItemId: taskId,
action: "status_changed",
actorId: null,
data: { from: item.status, to: "in_review" },
data: { from: item.status, to: advanced.status },
}).catch((err) =>
console.error("[task-board] in_review activity write failed", err),
);
Expand Down Expand Up @@ -1550,10 +1551,17 @@ export class TaskBoardStorage {
}

/**
* Flip a task to In Review only if it is still `in_progress`, returning the
* Flip a task to In Review only if it is still In Progress, returning the
* updated item or null when another caller already moved it.
*
* The `where status = 'in_progress'` predicate is the whole point: it makes
* `lanes` defaults to Studio's own board — the only board this ever ran
* against until a real column-based board could reach it too. An org-owned
* board's progress/review columns are whatever it named them, not the
* literals `"in_progress"`/`"in_review"`: hardcoding those made the WHERE
* match nothing (the advance silently never fired) and, had it matched,
* would have written a status that names no column on that board.
*
* The `where status = lanes.progress` predicate is the whole point: it makes
* the advance idempotent under concurrency, which the plain `update()` is not.
* See the caller above for what the duplicates cost.
*
Expand All @@ -1566,17 +1574,22 @@ export class TaskBoardStorage {
id: string,
organizationId: string,
by: string,
lanes: { progress: string | null; review: string | null } = {
progress: "in_progress",
review: "in_review",
},
): Promise<TaskBoardItem | null> {
if (lanes.progress === null || lanes.review === null) return null;
const row = await this.db
.updateTable("task_board_items")
.set({
status: "in_review",
status: lanes.review,
updated_by: by,
updated_at: new Date().toISOString(),
})
.where("id", "=", id)
.where("organization_id", "=", organizationId)
.where("status", "=", "in_progress")
.where("status", "=", lanes.progress)
.where("dismissed_at", "is", null)
.returningAll()
.executeTakeFirst();
Expand Down
Loading